Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.79%. Comparing base (fea85a5) to head (678a845).

@@            Coverage Diff             @@
##           master    #1923      +/-   ##
==========================================
+ Coverage   95.77%   95.79%   +0.02%     
==========================================
  Files          29       29              
  Lines        7856     7896      +40     
  Branches     1183     1188       +5     
==========================================
+ Hits         7524     7564      +40     
  Misses        192      192              
  Partials      140      140              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adam-urbanczyk I need to better understand what you are thinking. The current Material class wraps Graphic3d_MaterialAspect and so it is more visualization based, but my thought was to add things like density as properties later. XCAFDoc_Material does not seem to gain us much in the way is physical properties. My intention is to create a more general-purpose material class that can be used for multiple purposes, including export. It could be possible to wrap multiple classes and have the properties be interfaces to each of those properties. So the "diffuse color" would get/set on Graphic3d_MaterialAspect, and "density" would be get/set on XCAFDoc_Material.

In the end this class should wrap XCAFDoc_VisMaterial and XCAFDoc_Material (thus not Graphic3d_*). I assume that the first (main) use case is not vis related, so XCAFDoc_Material should be prioritized.

NB: it can be used for now to simply store a name.

@adam-urbanczyk How about this?

Ok, let me take a look.

could you implement pickling?

@adam-urbanczyk I'll see what I can do.